Closed
Bug 1688569
Opened 4 years ago
Closed 4 years ago
Cannot disable DOM breakpoints from the Debugger in remote frames
Categories
(DevTools :: Debugger, defect, P3)
DevTools
Debugger
Tracking
(Fission Milestone:M7, firefox87 fixed)
| Tracking | Status | |
|---|---|---|
| firefox87 | --- | fixed |
People
(Reporter: jdescottes, Assigned: jdescottes)
References
(Blocks 1 open bug)
Details
(Whiteboard: dt-fission-m3-mvp )
Attachments
(1 file)
Spotted while writing the test for Bug 1687296.
STRs:
- enable Fission
- open a page with a remote frame (eg http://janodvarko.cz/tests/fission/case10/index.html)
- inspect an element from the remote frame
- add any DOM breakpoint on it from the inspector (eg Attribute modifiction)
- switch to the Debugger
- click on the DOM breakpoint checkbox to disable it
ER: The checkbox should become unchecked
AR: The checkbox remains checked, the breakpoint is still applied
Note you can still remove the breakpoint from the inspector.
|
||
Comment 1•4 years ago
|
||
Thank you for reporting this Julian.
I can reproduce that on my machine using STRs from comment #0
It works for me when Fission is disabled.
Honza
|
||
Comment 2•4 years ago
|
||
Tracking dt-fission-m3-mvp bugs for Fission M7 (blocking Beta experiment).
Fission Milestone: --- → M7
|
Assignee | |
Comment 3•4 years ago
|
||
Looks like a simple fix. The toolbox is not capturing all the possible walkers for its reducer at https://searchfox.org/mozilla-central/rev/0b2870194375d80b54608c39060884acb758c206/devtools/client/framework/toolbox.js#705-707 . Only top level targets are handled for now
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 4•4 years ago
|
||
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0f185f5d9769
[devtools] Watch DOM mutation breakpoints on all targets r=ochameau
|
||
Comment 6•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox87:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•